Fixing flake8 warnings#1567
Merged
ocefpaf merged 3 commits intopython-visualization:mainfrom Oct 10, 2022
Merged
Conversation
Conengmo
changed the title
Conengmo
approved these changes
Oct 7, 2022
Member
Conengmo
left a comment
Conengmo
left a comment
There was a problem hiding this comment.
Just check that tests pass before merging
Member
|
@pmains I fixed a few of the tests. Do you mind rebasing this one to get the latest CI config here? |
…port and _version.py newline error
Member
|
Everything is passing now. I'll send a new one to add .pre-commit afer merging this to avoid regressions. |
Merged
Member
|
Forgot to say but thank you @pmains for your work on this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing flake8 warnings, except unused folium.features.GeoJsonPopup import and _version.py newline error.
_version.py is not tracked and so changing that would have no effect on the codebase.
The unused import seemed possibly necessary inside of an init.py file.